« Turing Test PluginCreative Commons plugin for b2evolution v1.8 »

24 comments

Comment from: Rob Worley [Visitor] Email · http://www.robworley.com
Nice! I'm going to use this.

Nitpicky request would be to have a back office setting so that Acrolink will only do its magic once per keyword (i.e. only the first instance of a keyword is Acrolinked...subsequent instances remain unaltered).

Very cool (and necessary) plugin!
01/06/07 @ 12:20
Comment from: EdB [Member]
hmmm... That'd be rather grand! Don't have a clue how to code it, but it would be pretty slick.
01/06/07 @ 13:04
Comment from: Alturo [Visitor] Email · http://www.lacuchara.es
I wonder if I can see this plugin working?
01/08/07 @ 01:23
Comment from: EdB [Member]
Sorry, but I'm actually not using it. I have an installation that I test stuff on, but I don't link it anywhere because it's only for testing.
01/08/07 @ 06:00
Comment from: Rob Worley [Visitor] Email · http://www.robworley.com
Just a few bug type things to report.

1) I entered in a "Title Tag" with the single quote character (') in it, and it made a poo-poo. Might call for an htmlentites call or something. Or maybe a field validation to disallow single quotes. Didn't try double quotes.

2) When I fixed that keyword entry by entering in the keyword and a new "title tag" I got the following WARNING:
Notice: Use of undefined constant linkurl - assumed 'linkurl' in /I_am/hiding_the/directory_name/html/plugins/acrolink_plugin/_acrolink.plugin.php on line 155
01/08/07 @ 07:04
Comment from: Rob Worley [Visitor] Email · http://www.robworley.com
Alturo: I'm using it at my blog (link my name) but there's not much to "see". If you look at the entry for today (1/8), you'll see that the phrase "Heir to Fire" is hyperlinked to another site.

When I composed the blog entry, I didn't hyperlink that phrase. I just typed the phrase in. EdB's magical plugin then turned it automatically into a live hyperlink (based on how I configured things in the backoffice).
01/08/07 @ 07:07
Comment from: EdB [Member]
Hi Rob. Thanks for letting me know. I've got to work for a couple of days, so I can't do anything about the single quote problem, but I'll get a fix in place as soon as I can. I also have to find a better method of doing the case-insensitive thing because someone in the forums couldn't install the plugin the way it's currently written.

I'm glad I released it as 0.1 instead of pretending it was worthy of calling 1.0 :(

Watch this space or the forum thread (not the plugin page) for an update.
01/08/07 @ 07:34
Comment from: Rob Worley [Visitor] Email · http://www.robworley.com
Hey man. Bugs happen. I like the plugin just fine. Those few things I discovered have workarounds so I'm happy.
01/09/07 @ 14:39
Comment from: Ben borges [Visitor] Email · http://blog.buzzworkers.com
It's working great now ! instalation is perfect :) great job on updating the plugin! thanks alot !
01/17/07 @ 01:55
Comment from: Charles LePage [Visitor] Email · http://www.comiclist.com
Any idea why, when I try to edit links, I get this:

AdminTabAction_EDIT failed :(
01/27/07 @ 17:26
Comment from: EdB [Member]
Nope. I mean, I know exactly where in the code that error comes from and I put them in there to be able to troubleshoot problems, but I don't know what's causing it. I wonder if it's something about 1.9.2 not liking something about my code? Are you able to add and delete keywords? I'm guessing you're using it as auto-links (not acronyms). I'm hoping you're using v0.4? I've finally got a 1.9.2 installation that I can play with so I'll test some stuff there, and I'll email you about trying to work on a corrective action. Gotta learn a bit more about the problem though.
01/27/07 @ 22:07
Comment from: Ian [Visitor] Email · http://www.ianlewis.org/
In order for acrolink to work in 1.9.2 all you have to add is a line

var $group = 'rendering';

to the beginning of the acrolink_plugin class source file.

Another note, when checking if a value is present in the $_GET array you should use quotes. e.g. $_GET["kwd"] and sometimes php installations complain if a value isn't present in the array so you should use the empty() method to check for presence or before checking the value.

I could produce a patch for you. Is there an e-mail I could send it to?
02/02/07 @ 21:49
Comment from: EdB [Member]
Hi Ian. Adding a $group value is not really required, though I will add it. What happens is plugins without a group get lumped into a group for ungrouped plugins. Not the worst fate in life eh? I've already added single quotes to the various _GETs, and "if ( isset(whatever)) ? true : false" for a few things that were giving unsightly notices to me when I tested it where I get my site hosted.

I was hoping to hear more from Charles about his issue before releasing 0.5 but it's starting to look like that won't happen. I'm not entirely sure, but I *think* his issue might have been due to trying to change the actual keyword instead of the link or title tag. So I guess it's time to let 'er rip eh? Perhaps I'll be close to where you would have gone?

I wish I had an answer to "if I don't use this on blog N why does it say the renderer is enabled on blog N?" but I don't, so that's all I can do. "Wish" is what I mean.
02/02/07 @ 22:48
Comment from: Robert Franco [Visitor] Email · http://blog.sourceoftitle.com
I am using the latest version with b2 v. 1.9.1 and it seems to be case sensitive. Is there an option I am missing to change that? If I try to set up 2 distinct entries in various cases, it does not display properly.
02/14/07 @ 11:10
Comment from: EdB [Member]
Aw crap you mean when it's rendering right? So like you can have case-insensitive keywords in your list but they don't work right in your blog? Aw crap.
02/14/07 @ 17:50
Comment from: Robert Franco [Visitor] Email · http://blog.sourceoftitle.com
Well... Here is what I set up:

Keyword: Source of Title
Link: http://www.sourceoftitle.com
Text: Source of Title

That worked great for "Source of Title", but did nothing with "SOURCE OF TITLE."

So I added this:

Keyword: SOURCE OF TITLE
Link: http://www.sourceoftitle.com
Text: Source of Title

It still worked fine for "Source of Title", but when it renders "SOURCE OF TITLE" it actually displays this:

Source of Title">SOURCE OF TITLE (the mixed case "Source of Title" is the link)

Seems odd. I thought that it was case IN-sensitive by default, which would eliminate the need for the second entry, which is what I would like.

And, BTW, I checked and I am using b2 v. 1.9.2, if that makes a difference.

Other than that, its a great plug-in - love it.
02/15/07 @ 08:46
Comment from: EdB [Member]
Okay cool. Not cool in that it's not working for you, but I understand the issue a bit better now. It should be case-sensitive when matching keywords, and a fair amount of work went into actually allowing the user to provide multiple case situations for their keyword list. The plugin also sorts your keywords from shortest to longest so that it matches 'foo' before it matches the middle of 'erm foo baz'.

I never gave any thought to what would happen if a a keyword happened to contain the same exact text in a different case as it's description.

Oh and the actual core of the plugin is work from someone else a long long time ago. Stuff I theoretically understand but don't feel good about tinkering with.

Anyway there seems to be 2 options available to me. First is to make sure it doesn't render something it's already rendered. That is supposed to be how it works, but it seems to me that is the nature of the problem you're having. Second is to turn off the need for multiple keywords to cover different cases. That was your assumption of operation, but the core of the code (the stuff I didn't actually create) is very case-sensitive.

urgh. This hurts my head. I'll work on it, but no promises when and if anything will come of the efforts. Tween now and then can you try changing the description so that it won't match another keyword? Like maybe hyphenate the description words?
02/16/07 @ 14:17
If you change this line (approx 364 ) from this :-

$this->search[] = '/(\b)'. $real_text .'(\b)/';

to this :-

$this->search[] = '/(\b)'. $real_text .'(\b)/i';

Then it should do case insenstive replacements ;)

Â¥
02/22/07 @ 04:58
Comment from: EdB [Member]
GOD DAM IT EVERYONE HAS A COOLER VISIGLYPH THAN ME AND THIS IS MY DAMNED DOMAIN NAME AND I PLAYED WITH SEEDS TILL I THOUGHT I HAD A COOL ONE - AND IT SUCKS!!! :evil:

Thanks dude. I thought it wouldn't be too hard, but I'm no good with regex stuff. Always gotta open a few reference tabs to get started, and even then I'm not happy playing there.

Been working on skins skins skins lately, but this has been on my plate. Gonna make it be an optional selection thing. Also the really big mission: only acrolink the first instance of a match.

aw crap ahm dronk. again. :cheeze:
02/22/07 @ 05:14
I normally just steal Blueyeds regex and then bend them to my will :rolleyes:

Making it only do a single replacement is a tad of a tougher nut to crack. If I ever work it out I'll let you know ;)

Damn, I've only been drunk once this year ...... dunno when I'll sober up so I can make it twice :D

Â¥
02/22/07 @ 05:28
Comment from: Robert Franco [Visitor] Email · http://blog.sourceoftitle.com
Thanks guys,

YaBBa's fix above worked like a charm.
02/28/07 @ 13:25
Comment from: Ian [Visitor] · http://www.ianlewis.org
Hey,

One more thing. I think that Acrolink shouldn't render matching text into a link if it's already in an anchor tag. I applied that to the code that checks if it's inside a code or pre tag around line 381. It seems to work well on my site but I haven't exaustively tested it.

if( stristr( $content, '<code' ) !== false || stristr( $content, '<pre' ) !== false || stristr( $content, '<a' ) !== false) {
$content = callback_on_non_matching_blocks( $content, '~<(code|pre|a)[^>]*>.*?</\1>~is', array( & $this, 'ReplaceTagSafe' ) );
} else {
$content = $this->ReplaceTagSafe($content);
}
05/23/07 @ 00:11
Comment from: Muncher [Visitor] · http://muncherw.com
It works nicely when I make a post but when someone makes a comment it doesn't work. I wonder if this can be made to work with comments as well.
07/13/07 @ 11:00
Comment from: EdB [Member]
I hadn't thought of that, and I don't know if the hooks exist to do it, but for sure it would be way cool. I'm busy busy busy with webwork projects, but yeah this will be an important improvement when I find time to play with this again.

Thanks for the great idea!
07/13/07 @ 12:27

Comments are closed for this post.


[Contact] Powered by b2evolution v2.4.2